Skip to content

Convert DataFrame.rename to keyword only; simplify axis validation #29140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jan 9, 2020
Merged

Convert DataFrame.rename to keyword only; simplify axis validation #29140

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
f09c6df
Worked around frame edges
WillAyd Oct 21, 2019
66acc90
Fixed frame tests
WillAyd Oct 21, 2019
177a440
Fixed Series tests
WillAyd Oct 21, 2019
b66e9e2
whatsnew
WillAyd Oct 21, 2019
2415e46
Cleaned up test cases
WillAyd Oct 21, 2019
296a9df
style updates
WillAyd Oct 21, 2019
6ba8518
Merge remote-tracking branch 'upstream/master' into fix-rename
WillAyd Jan 8, 2020
4128780
post merge fixes
WillAyd Jan 8, 2020
2776c7d
style fixups
WillAyd Jan 8, 2020
8e20fa4
fixups
WillAyd Jan 8, 2020
cca8eed
Added okexcept
WillAyd Jan 9, 2020
1f8e1cf
Black fixup
WillAyd Jan 9, 2020
4dc8bbe
mypy fixups
WillAyd Jan 9, 2020
1b261f8
flake8
WillAyd Jan 9, 2020
b5e54bd
Merge remote-tracking branch 'upstream/master' into fix-rename
WillAyd Jan 9, 2020
ab1ee2e
Comments addressed
WillAyd Jan 9, 2020
af0b7c5
minor fixups
WillAyd Jan 9, 2020
d5d812c
bound typevar to self
WillAyd Jan 9, 2020
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
minor fixups
  • Loading branch information
@WillAyd
WillAyd committed Jan 9, 2020
commit af0b7c5f45781cd31930b7809ce10400a9938ba3
2 changes: 1 addition & 1 deletion pandas/_typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
Axes = Collection

# For functions like rename that convert one label to another
Renamer = Union[Mapping[Hashable, Any], Callable[[Hashable], Hashable]]
Renamer = Union[Mapping[Label, Any], Callable[[Label], Label]]

# to maintain type information across generic functions and parametrization
T = TypeVar("T")
2 changes: 1 addition & 1 deletion pandas/core/series.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3916,7 +3916,7 @@ def rename(

Parameters
----------
axis : int or str
axis : {0 or "index"}
Unused. Accepted for compatability with DataFrame method only.
index : scalar, hashable sequence, dict-like or function, optional
Functions or dict-like are transformations to apply to
Expand Down