Skip to content

Fix mypy error messages in pandas/test/tseries/offsets/test_offsets.py #29340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 7, 2019
Merged

Fix mypy error messages in pandas/test/tseries/offsets/test_offsets.py #29340

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a8b2d93
Activate mypy and fix issues in test_offsets
samuelsinayoko Nov 2, 2019
4340a3c
flake8
samuelsinayoko Nov 2, 2019
c26cd0f
isort
samuelsinayoko Nov 2, 2019
ba19998
don't change import order in pandas_web
samuelsinayoko Nov 2, 2019
987b3f5
Rename apply case type
samuelsinayoko Nov 2, 2019
6b27d71
Use proper offset type not int in test offset cases
samuelsinayoko Nov 6, 2019
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rename apply case type
  • Loading branch information
@samuelsinayoko
samuelsinayoko committed Nov 2, 2019
commit 987b3f596e5731d69bd83d42675c49cb22f7ae4b
10 changes: 5 additions & 5 deletions pandas/tests/tseries/offsets/test_offsets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ def test_to_M8():
#####
# DateOffset Tests
#####
OffsetTestCaseList = List[Tuple[int, Dict[datetime, datetime]]]
_ApplyCases = List[Tuple[int, Dict[datetime, datetime]]]
Copy link
Member

@WillAyd WillAyd Nov 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
_ApplyCases = List[Tuple[int, Dict[datetime, datetime]]]
_ApplyCases = List[Tuple[BaseOffset, Dict[datetime, datetime]]]

Kind of tricky but I don't think int is in play at all here but these are rather all BaseOffset subclasses.

This only "works" because there is no stub for pandas.tseries.offsets and all of the instances here resolve to Any. Assumedly if we stubbed that module it would cause failures if this stays as int
Copy link
Contributor Author

@samuelsinayoko samuelsinayoko Nov 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point. Have just pushed this change.


class Base:
Expand Down Expand Up @@ -742,7 +742,7 @@ def test_onOffset(self):
for offset, d, expected in tests:
assert_onOffset(offset, d, expected)

apply_cases = [] # type: OffsetTestCaseList
apply_cases = [] # type: _ApplyCases
apply_cases.append(
(
BDay(),
Expand Down Expand Up @@ -2630,7 +2630,7 @@ def test_onOffset(self, case):
offset, d, expected = case
assert_onOffset(offset, d, expected)

apply_cases = [] # type: OffsetTestCaseList
apply_cases = [] # type: _ApplyCases
apply_cases.append(
(
CDay(),
Expand Down Expand Up @@ -2877,7 +2877,7 @@ def test_onOffset(self, case):
offset, d, expected = case
assert_onOffset(offset, d, expected)

apply_cases = [] # type: OffsetTestCaseList
apply_cases = [] # type: _ApplyCases
apply_cases.append(
(
CBMonthEnd(),
Expand Down Expand Up @@ -3026,7 +3026,7 @@ def test_onOffset(self, case):
offset, dt, expected = case
assert_onOffset(offset, dt, expected)

apply_cases = [] # type: OffsetTestCaseList
apply_cases = [] # type: _ApplyCases
apply_cases.append(
(
CBMonthBegin(),
Expand Down