REF: rename 'labels' to 'codes' in algorithms.safe_sort and ._factorize #29552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Returns | ||
| ------- | ||
| labels : ndarray | ||
| codes : ndarray |
Member
There was a problem hiding this comment.
do we necessarily know the dtype? e.g. could this be ndarray[int64]?
Contributor Author
There was a problem hiding this comment.
As it's implemented, codes will always be of type ndarray[int64]. I've got a suspicion taht there are cases where would like it to return arrays of fewer bits, but yes, as it is now, it always is an int64 array.
jreback reviewed Nov 12, 2019
| def safe_sort( | ||
| values, | ||
| labels=None, | ||
| codes=None, |
Contributor
There was a problem hiding this comment.
followup to type this would be great
Contributor
| thanks @topper-123 if you'd like to followup with typing where indicated would be great. |
Reksbril pushed a commit to Reksbril/pandas that referenced this pull request Nov 18, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Finishes up the renaming started by #29509 in
core.algorithmsof 'labels' to 'codes.' Also renames in related tests.