Skip to content

PERF: improve conversion to BooleanArray from int/float array #30095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 9, 2019
Merged

PERF: improve conversion to BooleanArray from int/float array #30095

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ee64bd6
PERF: improve conversion to BooleanArray from int/float array
ethanywang Dec 5, 2019
4993578
Merge branch 'master' into int_float_to_boolean
ethanywang Dec 5, 2019
3da324e
DOC: add issue number into whatsnew list
ethanywang Dec 6, 2019
788820f
PERF: remove redundant copy() in booleanArray
ethanywang Dec 6, 2019
2d5455c
TST: Update some test of boolean array from int/float np.ndarray
ethanywang Dec 6, 2019
5c3e4aa
STY: Change values.dtype comparation
ethanywang Dec 6, 2019
66fa559
TST: Add exception test from np.array
ethanywang Dec 8, 2019
3dcbbd6
ASV: add array benchmark
ethanywang Dec 8, 2019
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions pandas/core/arrays/boolean.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,9 +130,18 @@ def coerce_to_array(values, mask=None, copy: bool = False):
if isinstance(values, np.ndarray) and values.dtype == np.bool_:
if copy:
values = values.copy()
elif isinstance(values, np.ndarray) and values.dtype in (np.int_, np.float_):
values_copy = values.copy()

mask_values = isna(values)
values = np.zeros(len(values), dtype=bool)
values[~mask_values] = values_copy[~mask_values].astype(bool)

if not np.all(
values[~mask_values].astype(values.dtype) == values_copy[~mask_values]
):
raise TypeError("Need to pass bool-like values")
else:
# TODO conversion from integer/float ndarray can be done more efficiently
# (avoid roundtrip through object)
values_object = np.asarray(values, dtype=object)

inferred_dtype = lib.infer_dtype(values_object, skipna=True)
Expand Down