BUG: min/max on empty categorical fails #30227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
TomAugspurger left a comment
TomAugspurger left a comment There was a problem hiding this comment.
Can you add a .. versionchanged to indicate that an NA value is returned for empty arrays.
topper-123 reviewed Dec 12, 2019
jreback requested changes Dec 12, 2019
jreback reviewed Dec 12, 2019
jreback requested changes Dec 12, 2019
jreback reviewed Dec 12, 2019
TomAugspurger approved these changes Dec 17, 2019
Contributor
| Thanks! |
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffCurrently on master, the following fails:
ValueError: zero-size array to reduction operation maximum which has no identityOther dtypes return
NaNwhen callingmin()ormax()on an empty Series. This PR changes the behavior of Categoricals to be the same.Note that current behavior causes a downstream bug in Dask here: dask/dask#5645, so this PR could fix that bug as well.