BUG: raise on non-hashable Index name, closes #29069 #30335
Conversation
| To close #29069, Index.name should probably be a settable property, and the setter should validate that the name is hashable. Any perf concerns here? Things should be OK right? |
| huh, looks like i got confused by |
jreback left a comment
jreback left a comment There was a problem hiding this comment.
can you also add a whatsnew note
| Are we OK with being able to set MultiIndex.name? When I tried disallowing it, some tests broke |
| xref #11979 should we try to address that here while were at it? |
pandas/core/indexes/base.py Outdated
| | ||
| # GH#29069 | ||
| if not is_hashable(name): | ||
| raise TypeError(f"{cls_name}.name must be a hashable type") |
There was a problem hiding this comment.
can you use type(obj).name here?
pandas/core/indexes/base.py Outdated
| return RangeIndex(0, n, name=None) | ||
| | ||
| | ||
| def maybe_extract_name(name, obj, cls_name="Index"): |
There was a problem hiding this comment.
can you type and add a doc-string
| I think #19171 becomes easier after this. |
| | ||
| @name.setter | ||
| def name(self, value): | ||
| maybe_extract_name(value, None, type(self)) |
There was a problem hiding this comment.
in series.py you can change name.setter to use maybe_extract_name (ok for followon)
| return RangeIndex(0, n, name=None) | ||
| | ||
| | ||
| def maybe_extract_name(name, obj, cls) -> Optional[Hashable]: |
There was a problem hiding this comment.
see my comment above, can be more general so need to relocate i think as this is common between series/index)
| thanks |
…ndexing-1row-df * upstream/master: (333 commits) CI: troubleshoot Web_and_Docs failing (pandas-dev#30534) WARN: Ignore NumbaPerformanceWarning in test suite (pandas-dev#30525) DEPR: camelCase in offsets, get_offset (pandas-dev#30340) PERF: implement scalar ops blockwise (pandas-dev#29853) DEPR: Remove Series.compress (pandas-dev#30514) ENH: Add numba engine for rolling apply (pandas-dev#30151) [ENH] Add to_markdown method (pandas-dev#30350) DEPR: Deprecate pandas.np module (pandas-dev#30386) ENH: Add ignore_index for df.drop_duplicates (pandas-dev#30405) BUG: The setting xrot=0 in DataFrame.hist() doesn't work with by and subplots pandas-dev#30288 (pandas-dev#30491) CI: Fix GBQ Tests (pandas-dev#30478) Bug groupby quantile listlike q and int columns (pandas-dev#30485) ENH: Add ignore_index for df.sort_values and series.sort_values (pandas-dev#30402) TYP: Typing hints in pandas/io/formats/{css,csvs}.py (pandas-dev#30398) BUG: raise on non-hashable Index name, closes pandas-dev#29069 (pandas-dev#30335) Replace "foo!r" to "repr(foo)" syntax pandas-dev#29886 (pandas-dev#30502) BUG: preserve EA dtype in transpose (pandas-dev#30091) BLD: add check to prevent tempita name error, clsoes pandas-dev#28836 (pandas-dev#30498) REF/TST: method-specific files for test_append (pandas-dev#30503) marked unused parameters (pandas-dev#30504) ...
3 participants
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff