ENH: accept a dictionary in plot colors #31071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
5 tasks
WillAyd requested changes Jan 16, 2020
MarcoGorelli force-pushed the issue-8193 branch from ac5a96f to 65597a0 Compare 
jreback requested changes Jan 18, 2020
MarcoGorelli force-pushed the issue-8193 branch 2 times, most recently from 73ecd09 to 7a45f5b Compare MarcoGorelli changed the title MarcoGorelli force-pushed the issue-8193 branch from 7a45f5b to 95059a9 Compare MarcoGorelli changed the title 
Member Author
| @jreback have done some docstring-sharing, here are some screenshots:
|
MarcoGorelli force-pushed the issue-8193 branch from 95059a9 to a71f49a Compare 
jreback approved these changes Jan 24, 2020
Contributor
| great lgtm. if @datapythonista or @simonjayhawkins have any comments on the doc-strings otherwise merge away. |
datapythonista approved these changes Jan 24, 2020
Member
datapythonista left a comment
datapythonista left a comment There was a problem hiding this comment.
Great PR, nice feature. Thanks!
MarcoGorelli changed the title Contributor
| thanks @MarcoGorelli |
keechongtan added a commit to keechongtan/pandas that referenced this pull request Jan 27, 2020
…ndexing-1row-df * upstream/master: (194 commits) DOC Remove Python 2 specific comments from documentation (pandas-dev#31198) Follow up PR: pandas-dev#28097 Simplify branch statement (pandas-dev#29243) BUG: DatetimeIndex.snap incorrectly setting freq (pandas-dev#31188) Move DataFrame.info() to live with similar functions (pandas-dev#31317) ENH: accept a dictionary in plot colors (pandas-dev#31071) PERF: add shortcut to Timestamp constructor (pandas-dev#30676) CLN/MAINT: Clean and annotate stata reader and writers (pandas-dev#31072) REF: define _get_slice_axis in correct classes (pandas-dev#31304) BUG: DataFrame.floordiv(ser, axis=0) not matching column-wise bheavior (pandas-dev#31271) PERF: optimize is_scalar, is_iterator (pandas-dev#31294) BUG: Series rolling count ignores min_periods (pandas-dev#30923) xfail sparse warning; closes pandas-dev#31310 (pandas-dev#31311) REF: DatetimeIndex.get_value wrap DTI.get_loc (pandas-dev#31314) CLN: internals.managers (pandas-dev#31316) PERF: avoid copies if possible in fill_binop (pandas-dev#31300) Add test for multiindex json (pandas-dev#31307) BUG: passing TDA and wrong freq to TimedeltaIndex (pandas-dev#31268) BUG: inconsistency between PeriodIndex.get_value vs get_loc (pandas-dev#31172) CLN: remove _set_subtyp (pandas-dev#31301) CI: Updated version of macos image (pandas-dev#31292) ...
Member Author
| Happy to help, thanks @Leostayner for having started this |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is a resurrection of #28659. Have kept the original commit history, just rebased and added docstrings.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff