Skip to content

ERR: Raise NotImplementedError with BaseIndexer and certain rolling operations #33057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 29, 2020
Merged

ERR: Raise NotImplementedError with BaseIndexer and certain rolling operations #33057

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
474f5c1
ERR: Raise NotImplementedError with BaseIndexer and certain rolling o…
Mar 27, 2020
c92d86d
Lint
Mar 27, 2020
3dbb65f
Fix typing
Mar 27, 2020
c4dd78d
Add back tick mark
Mar 27, 2020
3930963
black
Mar 27, 2020
bd3eb29
isort and fix whatsnew
Mar 27, 2020
af71e07
Create common function for check
Mar 27, 2020
33c2403
Merge remote-tracking branch 'upstream/master' into notimplementedcus…
Mar 28, 2020
71a5db1
make validation function a common function
Mar 28, 2020
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Lint
  • Loading branch information
Matt Roeschke committed Mar 27, 2020
commit c92d86d2e21bf33cc731ecb8e839d956ca406d80
4 changes: 2 additions & 2 deletions pandas/core/window/rolling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,8 +404,8 @@ def _get_window_indexer(
if isinstance(self.window, BaseIndexer):
if isinstance(func_name, str) and func_name not in BASEINDEXER_WHITELIST:
raise NotImplementedError(
f"{func_name} is not supported with using a BaseIndexer subclasses. "
f"You can use .apply() with {func_name}."
f"{func_name} is not supported with using a BaseIndexer "
f"subclasses. You can use .apply() with {func_name}."
)
return self.window
if self.is_freq_type:
Expand Down