32380 deprecate squeeze in groupby #33218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mroeschke reviewed Apr 1, 2020
mroeschke requested changes Apr 1, 2020
WillAyd requested changes Apr 1, 2020
Member
WillAyd left a comment
WillAyd left a comment There was a problem hiding this comment.
Thanks for doing this - looks pretty good. As noted by @mroeschke looks like you did a little more work than was required; shouldn't remove anything just yet only warn the user appropriately
mroeschke reviewed Apr 3, 2020
mroeschke reviewed Apr 3, 2020
mroeschke reviewed Apr 3, 2020
Member
| We will still need a whatsnew entry for this (the one you had in a prior commit was good iirc) |
Member Author
| @mroeschke I have added the whats new entry. |
Member
| Looks good. Just need to merge master to fix the merge conflict and address @WillAyd's comment. |
Co-Authored-By: William Ayd <william.ayd@icloud.com>
Member Author
Done |
� Conflicts: � doc/source/whatsnew/v1.1.0.rst � pandas/core/frame.py � pandas/core/series.py
mroeschke approved these changes Apr 19, 2020
Contributor
| Looks good. Can you update. |
� Conflicts: � doc/source/whatsnew/v1.1.0.rst � pandas/core/series.py
Member Author
Done |
topper-123 approved these changes May 22, 2020
Member
| Ci failure should be unrelated - can you merge master and repush? |
Contributor
| thanks @phofl very nice. |
This was referenced May 22, 2020
3 tasks
rapids-bot bot pushed a commit to rapidsai/cudf that referenced this pull request Jul 19, 2024
In pandas, this argument was deprecated in pandas 1.x and removed in pandas 2.x. xref pandas-dev/pandas#33218 Looks like in cudf this argument was never implemented, so to align with pandas, I think it should be OK to just remove this argument Authors: - Matthew Roeschke (https://github.com/mroeschke) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) URL: #16312
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffI deprecated the squeeze keyword. I think I got every points this keyword was used.
I hope that I considered every point necessary to deprecate a keyword. I tried to use other points were a keyword was deprecated as example.