Skip to content

BUG: Fixed concat with reindex and extension types #33522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 1, 2020
Merged

BUG: Fixed concat with reindex and extension types #33522

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
bd316c3
BUG: Fixed concat with reindex and extension types
TomAugspurger Apr 10, 2020
87a1d31
Merge remote-tracking branch 'upstream/master' into concat-empty-ea
TomAugspurger May 28, 2020
7fc30a0
rebase
TomAugspurger May 28, 2020
709ac02
Merge remote-tracking branch 'upstream/master' into concat-empty-ea
TomAugspurger Jun 1, 2020
93f0069
Merge remote-tracking branch 'upstream/master' into concat-empty-ea
TomAugspurger Jun 19, 2020
187551c
fixup
TomAugspurger Jun 19, 2020
a83a5fe
cleanup
TomAugspurger Jun 19, 2020
2c2b9b5
Merge remote-tracking branch 'upstream/master' into concat-empty-ea
TomAugspurger Jun 22, 2020
13c1fe7
fixups
TomAugspurger Jun 22, 2020
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
cleanup
  • Loading branch information
@TomAugspurger
TomAugspurger committed Jun 19, 2020
commit a83a5fe7af7e15d94e540c0cd791d0b710a213c5
2 changes: 0 additions & 2 deletions pandas/core/internals/concat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,6 @@ def _get_empty_dtype_and_na(join_units):

upcast_classes = defaultdict(list)
null_upcast_classes = defaultdict(list)

for dtype, unit in zip(dtypes, join_units):
if dtype is None:
continue
Expand All @@ -386,7 +385,6 @@ def _get_empty_dtype_and_na(join_units):
elif is_datetime64tz_dtype(dtype):
upcast_cls = "datetimetz"

Copy link
Contributor

@jreback jreback Jun 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sort of dumb, but no blank lines before/after
# may need to move sparse back up
elif is_extension_array_dtype(dtype):
upcast_cls = "extension"

Expand Down