-
- Notifications
You must be signed in to change notification settings - Fork 19.4k
ENH: Implement IntegerArray.sum #33538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jorisvandenbossche merged 8 commits into pandas-dev:master from dsaxton:nullable-int-sum Apr 25, 2020
Merged
Changes from 1 commit
Commits
Show all changes
8 commits Select commit Hold shift + click to select a range
f8d8d25 ENH: Implement IntegerArray.sum
dsaxton 85d66ab Update signature and tests
dsaxton a44ae16 Merge remote-tracking branch 'upstream/master' into nullable-int-sum
dsaxton aa7ee1a PR num
dsaxton 5fdb586 Release note
dsaxton 1d8eb4d Merge remote-tracking branch 'upstream/master' into nullable-int-sum
dsaxton 32a6b4e numpy compat
dsaxton 9ee8ab2 Merge remote-tracking branch 'upstream/master' into nullable-int-sum
dsaxton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| | @@ -113,6 +113,17 @@ def test_value_counts_empty(): | |
| tm.assert_series_equal(result, expected) | ||
| | ||
| | ||
| @pytest.mark.parametrize("skipna", [True, False]) | ||
| @pytest.mark.parametrize("min_count", [0, 4]) | ||
| def test_integer_array_sum(skipna, min_count): | ||
| Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is e.g. Series[Int64].sum() or DataFrame[Int64].sum() fixed by this? Contributor Author There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Those are actually already working, just not for IntegerArray specifically | ||
| arr = pd.array([1, 2, 3, None], dtype="Int64") | ||
| result = arr.sum(skipna=skipna, min_count=min_count) | ||
| if skipna and min_count == 0: | ||
| assert result == 6 | ||
| else: | ||
| assert result is pd.NA | ||
| | ||
| | ||
| # TODO(jreback) - these need testing / are broken | ||
| | ||
| # shift | ||
| | ||
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably should make the signature match PandasArray.sum etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, and we still want to keep axis (even though it wouldn't be used here)?