Skip to content

BUG: GroupBy.count() and GroupBy.sum() incorreclty return NaN instead of 0 for missing categories #35280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 37 commits into from
Aug 7, 2020
Merged

BUG: GroupBy.count() and GroupBy.sum() incorreclty return NaN instead of 0 for missing categories #35280

Changes from 1 commit
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
ec577d7
set self.observed=True for .sum() and .count() so that reindex can be…
smithto1 Jul 11, 2020
586b1bd
wrote test for .sum() and .count() exception handling
smithto1 Jul 11, 2020
ec4bd28
black
smithto1 Jul 11, 2020
eed48cb
updated pivot tests
smithto1 Jul 11, 2020
88d8a14
whatsnew
smithto1 Jul 11, 2020
940b32e
comments
smithto1 Jul 11, 2020
3e39f1a
black
smithto1 Jul 11, 2020
bd4c4fe
.sum() and .count() create inner groupby with observed=True, and then…
smithto1 Jul 14, 2020
fcbb58b
modify self.observed with a context manager
smithto1 Jul 15, 2020
5f89c17
added comments
smithto1 Jul 15, 2020
7ed0982
merging master
smithto1 Jul 15, 2020
9da5b18
Fixed import order that caused Linting error
smithto1 Jul 15, 2020
534d60f
addressing comments
smithto1 Jul 16, 2020
b323c9c
merging master
smithto1 Jul 16, 2020
d2abd4d
fixing whatsnew comment
smithto1 Jul 16, 2020
361098a
ammend comment
smithto1 Jul 16, 2020
9879199
ammend comment
smithto1 Jul 16, 2020
39ee6d0
addressing PR comments
smithto1 Jul 16, 2020
fc1a846
ammend comment
smithto1 Jul 16, 2020
f774288
amend comment
smithto1 Jul 17, 2020
1986f51
amend comment (just to rerun tests
smithto1 Jul 17, 2020
c4c1a92
ammend comment to start new tests (tests failing due to some flakey t…
smithto1 Jul 17, 2020
7093c91
merging master
smithto1 Jul 18, 2020
5f8ba0e
amend comment to kick off tests
smithto1 Jul 18, 2020
49b5fc8
ammend test to kick off tests
smithto1 Jul 18, 2020
0454e3a
merging master
smithto1 Jul 26, 2020
28794e3
fixed merge
smithto1 Jul 26, 2020
f616d5a
merge fix
smithto1 Jul 26, 2020
80d4b7d
udpate comment to kick off tests
smithto1 Jul 27, 2020
442ad1d
amend comment to restart checks
smithto1 Aug 1, 2020
be8b78c
Merge remote-tracking branch 'upstream/master' into issue31422-v7
smithto1 Aug 5, 2020
ed99b60
doc updates
smithto1 Aug 5, 2020
528ff7e
restart tests
smithto1 Aug 5, 2020
b2a331f
Merge remote-tracking branch 'upstream/master' into issue31422-v7
smithto1 Aug 6, 2020
cb010fa
Merge branch 'master' into issue31422-v7
jreback Aug 7, 2020
d6ebe10
merge
smithto1 Aug 7, 2020
f575687
merge
smithto1 Aug 7, 2020
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge remote-tracking branch 'upstream/master' into issue31422-v7
  • Loading branch information
@smithto1
smithto1 committed Aug 5, 2020
commit be8b78c6ff493f6c20242d4d90392e9d529ebdbf

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.