BUG: date_range doesn't propagate ambigous=False to tz_localize #35302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mroeschke reviewed Jul 16, 2020
pandas/core/arrays/datetimes.py Outdated
| # start/end as well to compare | ||
| if start is not None: | ||
| start = start.tz_localize(tz).asm8 | ||
| start = start.tz_localize(tz, ambiguous).asm8 |
Member
There was a problem hiding this comment.
Could you also pass nonexistent and write a test case for that issue as well?
mroeschke reviewed Jul 16, 2020
mroeschke reviewed Jul 16, 2020
doc/source/whatsnew/v1.1.0.rst Outdated
| | ||
| - Bug in :func:`to_datetime` with ``infer_datetime_format=True`` where timezone names (e.g. ``UTC``) would not be parsed correctly (:issue:`33133`) | ||
| - | ||
| - Bug in :func:`date_range` was raising AmbiguousTimeError for valid input with `ambiguous=False` (:issue:`35297`) |
Member
There was a problem hiding this comment.
Could you move this to 1.2.0?
Contributor Author
There was a problem hiding this comment.
For sure! I don't think we have doc/source/whatsnew/v1.2.0.rst atm - shall I create it?
Contributor Author
| @mroeschke Getting an error in the doctests that I think is unrelated to this PR: I merged with master just now so I don't think it's because this branch is out-of-date |
Member
| No worries, looks unrelated to this PR Actually sorry, could you move the creation of the 1.2.0 whatsnew doc to a separate PR? Would make this PR cleaner. |
Merged
mroeschke reviewed Jul 20, 2020
mroeschke reviewed Jul 20, 2020
mroeschke approved these changes Jul 29, 2020
Member
| Thanks @arw2019 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff