TYP: annotate plotting based on _get_axe_freq #35960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
simonjayhawkins approved these changes Aug 28, 2020
Member
simonjayhawkins left a comment
simonjayhawkins left a comment There was a problem hiding this comment.
Thanks @jbrockmendel lgtm pending green
Member
| Thanks @jbrockmendel |
AlexKirko pushed a commit to AlexKirko/pandas that referenced this pull request Aug 31, 2020
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
In some places in plotting
axis an Axes object and in other its an Axis object. Current goal is to pin these down.in timeseries._get_ax_freq we call
ax.get_shared_x_axes(), which is an Axes method that does not exist on Axis. This annotates that usage and annotates all the other places where we can infer Axes from that.