Skip to content

Conversation

@ShyamDesai
Copy link

@ShyamDesai ShyamDesai commented Sep 6, 2020

… 1 (#32550)

Copy link
Contributor

@dsaxton dsaxton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ShyamDesai for the PR

.. _indexing.deprecate_ix:

IX indexer is deprecated
ix indexer is deprecated
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed this to 'ix' as it is a deprecated function referred to as such, not 'IX'. Please let me know if there's an issue with this @dsaxton

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ix is removed, this should be taken out entirely (doesnt have to be this PR)

@github-actions
Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Oct 24, 2020
@dsaxton
Copy link
Contributor

dsaxton commented Oct 24, 2020

@ShyamDesai can you merge master to fix conflicts? This generally looks good.

@mroeschke
Copy link
Member

Thanks but going to close this PR as stale. Please ping us if you would like to keep working on this.

@mroeschke mroeschke closed this Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

4 participants