BUG: Don't copy DataFrame columns as metadata #37205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
See https://github.com/pandas-dev/pandas/pull/37186/files#r506978889. Basically, we don't want to accidentally do `series.name = dataframe.name` and try to set a column.
Contributor Author
| Also cc @arw2019 |
5 tasks
Contributor
| thanks @TomAugspurger |
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Oct 26, 2020
Member
Indeed, I also can't think of a situation where it would break anything (and our tests using pandas master didn't show up any failure). Whenever a metadata attribute existed on |
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
See https://github.com/pandas-dev/pandas/pull/37186/files#r506978889.
Basically, we don't want to accidentally do
series.name = dataframe.nameand try to set a column.cc @jorisvandenbossche. This could conceivably affect geopandas, since geodataframe has different metadata than geoseries: https://github.com/geopandas/geopandas/blob/924cdf65c7c15b01749d1cdd036c5c291e87b0f4/geopandas/geodataframe.py#L83
But I don't think it'll actually break anything for you.