CLN refactor core indexes

pandas/core/indexes/api.py

@@ -282,7 +282,4 @@ def all_indexes_same(indexes):
  """
  itr = iter(indexes)
  first = next(itr)
- for index in itr:
- if not first.equals(index):
- return False
- return True
+ return all(first.equals(index) for index in itr)

pandas/core/indexes/base.py

@@ -906,9 +906,7 @@ def __repr__(self) -> str_t:
  if data is None:
  data = ""
 
- res = f"{klass_name}({data}{prepr})"
-
- return res
+ return f"{klass_name}({data}{prepr})"
 
  def _format_space(self) -> str_t:
 
@@ -987,7 +985,6 @@ def _format_with_header(
  if is_object_dtype(values.dtype):
  values = lib.maybe_convert_objects(values, safe=1)
 
- if is_object_dtype(values.dtype):
  result = [pprint_thing(x, escape_chars=("\t", "\r", "\n")) for x in values]
 
  # could have nans
@@ -1615,7 +1612,7 @@ def _drop_level_numbers(self, levnums: List[int]):
  Drop MultiIndex levels by level _number_, not name.
  """
 
- if len(levnums) == 0:
+ if not levnums:
  return self
  if len(levnums) >= self.nlevels:
  raise ValueError(
@@ -3170,7 +3167,7 @@ def get_indexer(
  "Reindexing only valid with uniquely valued Index objects"
  )
 
- if method == "pad" or method == "backfill":
+ if method in ["pad", "backfill"]:
  indexer = self._get_fill_indexer(target, method, limit, tolerance)
  elif method == "nearest":
  indexer = self._get_nearest_indexer(target, limit, tolerance)
@@ -3293,8 +3290,7 @@ def _filter_indexer_tolerance(
  ) -> np.ndarray:
  # error: Unsupported left operand type for - ("ExtensionArray")
  distance = abs(self._values[indexer] - target) # type: ignore[operator]
- indexer = np.where(distance <= tolerance, indexer, -1)
- return indexer
+ return np.where(distance <= tolerance, indexer, -1)
 
  # --------------------------------------------------------------------
  # Indexer Conversion Methods
@@ -3403,9 +3399,7 @@ def _convert_listlike_indexer(self, keyarr):
  keyarr : numpy.ndarray
  Return tuple-safe keys.
  """
- if isinstance(keyarr, Index):
- pass
- else:
+ if not isinstance(keyarr, Index):
  keyarr = self._convert_arr_indexer(keyarr)
 
  indexer = self._convert_list_indexer(keyarr)
@@ -3424,8 +3418,7 @@ def _convert_arr_indexer(self, keyarr):
  -------
  converted_keyarr : array-like
  """
- keyarr = com.asarray_tuplesafe(keyarr)
- return keyarr
+ return com.asarray_tuplesafe(keyarr)
 
  def _convert_list_indexer(self, keyarr):
  """
@@ -3793,9 +3786,8 @@ def _join_multi(self, other, how, return_indexers=True):
  other, level, how=how, return_indexers=return_indexers
  )
 
- if flip_order:
- if isinstance(result, tuple):
- return result[0], result[2], result[1]
+ if flip_order and isinstance(result, tuple):
+ return result[0], result[2], result[1]
  return result
 
  @final
@@ -4340,7 +4332,7 @@ def append(self, other):
  to_concat = [self]
 
  if isinstance(other, (list, tuple)):
- to_concat = to_concat + list(other)
+ to_concat += list(other)
  else:
  to_concat.append(other)
 
@@ -4835,9 +4827,7 @@ def _should_fallback_to_positional(self) -> bool:
  """
  Should an integer key be treated as positional?
  """
- if self.holds_integer() or self.is_boolean():
- return False
- return True
+ return not self.holds_integer() and not self.is_boolean()
 
  def _get_values_for_loc(self, series: "Series", loc, key):
  """
@@ -5298,11 +5288,7 @@ def _validate_indexer(self, form: str_t, key, kind: str_t):
  """
  assert kind in ["getitem", "iloc"]
 
- if key is None:
- pass
- elif is_integer(key):
- pass
- else:
+ if key is not None and not is_integer(key):
  raise self._invalid_indexer(form, key)
 
  def _maybe_cast_slice_bound(self, label, side: str_t, kind):
@@ -5607,9 +5593,10 @@ def _cmp_method(self, other, op):
  elif op in {operator.ne, operator.lt, operator.gt}:
  return np.zeros(len(self), dtype=bool)
 
- if isinstance(other, (np.ndarray, Index, ABCSeries, ExtensionArray)):
- if len(self) != len(other):
- raise ValueError("Lengths must match to compare")
+ if isinstance(other, (np.ndarray, Index, ABCSeries, ExtensionArray)) and len(
+ self
+ ) != len(other):
+ raise ValueError("Lengths must match to compare")
 
  if not isinstance(other, ABCMultiIndex):
  other = extract_array(other, extract_numpy=True)
@@ -5930,10 +5917,11 @@ def trim_front(strings: List[str]) -> List[str]:
  """
  Trims zeros and decimal points.
  """
- trimmed = strings
- while len(strings) > 0 and all(x[0] == " " for x in trimmed):
- trimmed = [x[1:] for x in trimmed]
- return trimmed
+ if not strings:
+ return strings
+ while all(x[0] == " " for x in strings):
+ strings = [x[1:] for x in strings]
+ return strings
 
 
 def _validate_join_method(method: str):
@@ -6001,15 +5989,11 @@ def _maybe_cast_with_dtype(data: np.ndarray, dtype: np.dtype, copy: bool) -> np.
  except ValueError:
  data = np.array(data, dtype=np.float64, copy=copy)
 
- elif inferred == "string":
- pass
- else:
+ elif inferred != "string":
  data = data.astype(dtype)
  elif is_float_dtype(dtype):
  inferred = lib.infer_dtype(data, skipna=False)
- if inferred == "string":
- pass
- else:
+ if inferred != "string":
  data = data.astype(dtype)
  else:
  data = np.array(data, dtype=dtype, copy=copy)

pandas/core/indexes/datetimes.py

@@ -408,10 +408,9 @@ def _maybe_utc_convert(self, other: Index) -> Tuple["DatetimeIndex", Index]:
  this = self
 
  if isinstance(other, DatetimeIndex):
- if self.tz is not None:
- if other.tz is None:
- raise TypeError("Cannot join tz-naive with tz-aware DatetimeIndex")
- elif other.tz is not None:
+ if (self.tz is not None and other.tz is None) or (
+ self.tz is None and other.tz is not None
+ ):
  raise TypeError("Cannot join tz-naive with tz-aware DatetimeIndex")
 
  if not timezones.tz_compare(self.tz, other.tz):
@@ -745,8 +744,7 @@ def _get_string_slice(self, key: str):
  freq = getattr(self, "freqstr", getattr(self, "inferred_freq", None))
  parsed, reso = parsing.parse_time_string(key, freq)
  reso = Resolution.from_attrname(reso)
- loc = self._partial_date_slice(reso, parsed)
- return loc
+ return self._partial_date_slice(reso, parsed)
 
  def slice_indexer(self, start=None, end=None, step=None, kind=None):
  """