Skip to content

Conversation

@Alvinwuzw
Copy link

closes #37625
tests passed
read_excel funtion can now accept header={'Sheet1': 0, 'Sheet2': None} as dictionary with header for each sheet.

@@ -0,0 +1,67 @@
import sys
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do these two files do?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, It was added by mistake! I could remove it right away.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I make another pull request after resolving this?

@Alvinwuzw Alvinwuzw marked this pull request as draft December 16, 2020 00:21
@Alvinwuzw Alvinwuzw marked this pull request as ready for review December 16, 2020 00:28
@Alvinwuzw Alvinwuzw requested a review from arw2019 December 16, 2020 00:28
@jreback jreback changed the title Closes #37625 by adding new feature ENH: support none in header list #37625 Dec 16, 2020
Copy link
Contributor

@arw2019 arw2019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test? It should fail on master and pass on this branch. Look in pandas/io for what patterns we use and place it next to similar tests

@jreback jreback added the IO CSV read_csv, to_csv label Dec 22, 2020
@github-actions
Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Jan 22, 2021
Copy link
Contributor

@arw2019 arw2019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs a rebase, tests, and a whatsnew

also not sure this solution is quite right atm (if the CI failures are real)

@jreback
Copy link
Contributor

jreback commented Feb 11, 2021

closing as stale. if you want to continue, pls ping and can re-open.

@jreback jreback closed this Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

IO CSV read_csv, to_csv Stale

3 participants