Skip to content

Conversation

@MOHED1224
Copy link

Trying to improve the user experience and interaction with the webpage.

1.Edited button hover effect.
2. Make links open in new tabs instead of redirect in the current webpage because this may be not good for some people.
3. Added data manipulation note in the introduction section.

@MOHED1224
Copy link
Author

Just removing the errors in the first 2 commits.

@jreback
Copy link
Contributor

jreback commented Dec 17, 2020

so this is just a change to hover (1) right?

@jreback jreback added the Docs label Dec 17, 2020
@jreback jreback added this to the 1.3 milestone Dec 17, 2020
@jreback
Copy link
Contributor

jreback commented Dec 17, 2020

@MOHED1224
Copy link
Author

so this is just a change to hover (1) right?
yes

@datapythonista
Copy link
Member

Thanks @MOHED1224. I think it's fine here, but in general we prefer to not mix PRs with unrelated changes, even if they are small.

@jorisvandenbossche is this hover effect something that should be implemented here, or in the original sphinx theme?

@github-actions
Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Jan 17, 2021
@jorisvandenbossche
Copy link
Member

Sorry for the slow reply here

is this hover effect something that should be implemented here, or in the original sphinx theme?

At the moment the "custom-button" (and its css) is defined here in pandas, so a hover effect on it is also to be implemented in pandas.
Although long term we should probably look into replacing it with the buttons provided by sphinx-panels: https://sphinx-panels.readthedocs.io/en/latest/#link-buttons

Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@datapythonista
Copy link
Member

I'm going to close this. @MOHED1224 let's do this properly even if it's small. Can you open an issue with screenshots of the button you think should be improved, with and without your proposed hover. And tag me there, if there is agreement please reopen the PR only with those changes, and nothing else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

5 participants