TST: GH30999 Add match=msg to all pytest.raises in tests/reductions and add an error message to nanmedian #38720
+37 −15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…nd add error message to nanmedian
jorisvandenbossche requested changes Dec 27, 2020
… method in _check_stat_op
jreback added Error Reporting 
jreback approved these changes Dec 27, 2020
Contributor
jreback left a comment
jreback left a comment There was a problem hiding this comment.
lgtm. cc @jorisvandenbossche
…based on PR feedback Pass None, which means it matches any message.
…ll when bool_only is passed
jreback requested changes Dec 30, 2020
jreback approved these changes Dec 30, 2020
Contributor
| thanks @moink |
luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
…nd add an error message to nanmedian (pandas-dev#38720)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This pull request partially addresses xref #30999 to remove bare
pytest.raisesby addingmatch=msg. It doesn't close that issue as I have only addressed test modules in the pandas/tests/reductions directory.When going through the tests I found one case where the error message was the empty string. I decided that wasn't correct so I modified the
TypeErrorto inherit the error message from theValueErrorit was raising from. This made the error message similar to other messages in the same test.black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff