Skip to content

ENH: Add typing for pandas.core.frame.dropna #38968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

ENH: Add typing for pandas.core.frame.dropna #38968

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5d24561
TYP:Add typing for pandas.core.frame.dropna
rbpatt2019 Jan 5, 2021
f2733e3
BUG:Add missing `return None` statement for pandas.core.frame.dropna
rbpatt2019 Jan 5, 2021
f2e2bcf
TYP:Overload pandas.core.frame.dropna function signature
rbpatt2019 Jan 5, 2021
63d0410
CLN:Blacken code
rbpatt2019 Jan 5, 2021
bc0c5d2
CLN:Remove superfluous comment
rbpatt2019 Jan 5, 2021
55ef7f9
TYP:Remove default literals in signature overloads
rbpatt2019 Jan 5, 2021
5480288
Merge remote-tracking branch 'upstream/master' into BUG/38948
simonjayhawkins Mar 14, 2021
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
TYP:Add typing for pandas.core.frame.dropna 
Fixes GH38948.
  • Loading branch information
@rbpatt2019
rbpatt2019 committed Jan 5, 2021
commit 5d24561fefe2ac52456aa10bc4cb4192aa46d815
6 changes: 3 additions & 3 deletions pandas/core/frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5074,10 +5074,10 @@ def dropna(
self,
axis: Axis = 0,
how: str = "any",
thresh=None,
subset=None,
thresh Optional[int] = None,
subset: Optional[Union[Hashable, Sequence[Hashable]]] = None,
inplace: bool = False,
):
) -> Optional[DataFrame]:
Copy link
Member

@simonjayhawkins simonjayhawkins Jan 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you used #37137 as a example. However the motivation for that PR was to remove an assert df is not None from the codebase and the return type of Optional[DataFrame] not touched.

Not needed to be done in this PR, but just FYI if the motivation for adding the types is for the public api, then the return type should be the same type as self for subclassed DataFrames.
"""
Remove missing values.

Expand Down