Skip to content

ENH: Add typing for pandas.core.frame.dropna #38968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

ENH: Add typing for pandas.core.frame.dropna #38968

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5d24561
TYP:Add typing for pandas.core.frame.dropna
rbpatt2019 Jan 5, 2021
f2733e3
BUG:Add missing `return None` statement for pandas.core.frame.dropna
rbpatt2019 Jan 5, 2021
f2e2bcf
TYP:Overload pandas.core.frame.dropna function signature
rbpatt2019 Jan 5, 2021
63d0410
CLN:Blacken code
rbpatt2019 Jan 5, 2021
bc0c5d2
CLN:Remove superfluous comment
rbpatt2019 Jan 5, 2021
55ef7f9
TYP:Remove default literals in signature overloads
rbpatt2019 Jan 5, 2021
5480288
Merge remote-tracking branch 'upstream/master' into BUG/38948
simonjayhawkins Mar 14, 2021
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
CLN:Remove superfluous comment 
GH38948 pull request review
  • Loading branch information
@rbpatt2019
rbpatt2019 committed Jan 5, 2021
commit bc0c5d24bd6450a52ddd2e331ff1cf019b47f911
2 changes: 0 additions & 2 deletions pandas/core/frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5070,8 +5070,6 @@ def notna(self) -> DataFrame:
def notnull(self) -> DataFrame:
return ~self.isna()

# Overload function signature to prevent union of conflicting types
# As Optional[DataFrame] is really Union[DataFrame, None]
@overload
def dropna(
self,
Expand Down