Skip to content

Conversation

@shuaggar-sys
Copy link

@shuaggar-sys shuaggar-sys commented Feb 4, 2021

@pep8speaks
Copy link

pep8speaks commented Feb 4, 2021

Hello @shuaggar-sys! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-02-04 18:05:51 UTC
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shuaggar-sys - did you try building this locally to check it looks alright?

cd doc python make.py --single pandas.Index.get_indexer
@shuaggar-sys
Copy link
Author

on running the below i get stale output, i ran it before i added the first commit, the message is not updated in the generated html file.
python make.py --single pandas.Index.get_indexer

@MarcoGorelli
Copy link
Member

did you do python make.py clean?

@shuaggar-sys
Copy link
Author

Sorry for the rookie mistake, i did not do that. Yes everything looks fine after the build.

pandas_pr_ss

@MarcoGorelli MarcoGorelli added this to the 1.3 milestone Feb 5, 2021
indexer should be then used as an input to ndarray.take to align the
current data to the new index.
.. warning::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just add this in Notes. or just as a sentence here. this is not the level of a warning.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shuaggar-sys can you do this pls

@github-actions
Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Mar 10, 2021
@MarcoGorelli
Copy link
Member

closing as stale, please open a new PR if interested in continuing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

5 participants