fixed formatting on to_csv() for categorical datetypes #41173
Conversation
kyleolaughlin commented Apr 26, 2021
kyleolaughlin commented - closes #xxxx
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
mzeitlin11 left a comment
mzeitlin11 left a comment There was a problem hiding this comment.
Thanks for the pr @kyleolaughlin. Some comments, plus looks like you accidentally committed the file ctypes.__init__.cover.
Also, first thing any pr needs is tests!
| ) -> np.ndarray: | ||
| """ convert to our native types format """ | ||
| values = ensure_wrapped_if_datetimelike(values) | ||
| if isinstance(values, Categorical) and isinstance(values.categories[0], Timestamp): |
There was a problem hiding this comment.
You should be able to use .dtype to get the category type in a more stable way. Also, why is this timestamp specific? Do other datetimelike values work (and are tested?)
| result = result.astype(object, copy=False) | ||
| return result | ||
| | ||
| |
There was a problem hiding this comment.
Please remove the unrelated change here and in lines below
| Thanks @kyleolaughlin for the PR. what is the issue number this PR is addressing? |
simonjayhawkins added Bug Categorical 
| This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this. |
| Thanks for contributing @kyleolaughlin, closing as stale for now, but please ping to reopen if you'd like to continue working on this. |
3 participants
