Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
6af8280
DEPS: update setuptools min version
fangchenli Jun 29, 2021
7bc5a42
update doc
fangchenli Jun 29, 2021
9ac6943
add setuptools to environment.yml
fangchenli Jun 29, 2021
8a12e21
remove setuptools from environment.yml
fangchenli Jun 30, 2021
66af51b
Merge remote-tracking branch 'upstream/master' into fix-setuptools-mi…
fangchenli Jun 30, 2021
49958c8
Merge remote-tracking branch 'upstream/master' into fix-setuptools-mi…
fangchenli Jul 1, 2021
0b812a0
fix doc
fangchenli Jul 1, 2021
73d59fe
Update doc/source/development/contributing_environment.rst
fangchenli Jul 1, 2021
eff688c
Merge remote-tracking branch 'upstream/master' into fix-setuptools-mi…
fangchenli Jul 2, 2021
d2351cd
Merge remote-tracking branch 'origin/fix-setuptools-min-version' into…
fangchenli Jul 2, 2021
bfdeab3
Merge remote-tracking branch 'upstream/master' into fix-setuptools-mi…
fangchenli Jul 2, 2021
fc3919f
Merge remote-tracking branch 'upstream/master' into fix-setuptools-mi…
fangchenli Jul 6, 2021
a390612
Merge remote-tracking branch 'upstream/master' into fix-setuptools-mi…
fangchenli Jul 7, 2021
67ab670
Merge remote-tracking branch 'upstream/master' into fix-setuptools-mi…
fangchenli Jul 8, 2021
efb2fc7
add instruction for upgrading setuptools
fangchenli Jul 8, 2021
4d578be
remove code-block
fangchenli Jul 8, 2021
dee8fc0
Merge remote-tracking branch 'upstream/master' into fix-setuptools-mi…
fangchenli Jul 26, 2021
bd661a5
Merge remote-tracking branch 'upstream/master' into fix-setuptools-mi…
fangchenli Jul 26, 2021
36eb657
Merge remote-tracking branch 'upstream/master' into fix-setuptools-mi…
fangchenli Jul 26, 2021
1d6c1e4
add setuptools to requirements.txt
fangchenli Jul 26, 2021
2aba478
add toml to pre-commit dependency list
fangchenli Jul 26, 2021
37d2c4f
Merge remote-tracking branch 'upstream/master' into fix-setuptools-mi…
fangchenli Jul 26, 2021
fe7b039
Merge remote-tracking branch 'upstream/master' into fix-setuptools-mi…
fangchenli Aug 2, 2021
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
DEPS: update setuptools min version
  • Loading branch information
fangchenli committed Jun 29, 2021
commit 6af8280173e6d0d38a825225aea87df76ad7ec87
2 changes: 1 addition & 1 deletion doc/source/getting_started/install.rst
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ Visualization
========================= ================== =============================================================
Dependency Minimum Version Notes
========================= ================== =============================================================
setuptools 38.6.0 Utils for entry points of plotting backend
setuptools 51.0.0 Utils for entry points of plotting backend
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the notes suggest the min version we require is for using the plotting backend.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this doesn't need to be changed.

matplotlib 2.2.3 Plotting library
Jinja2 2.10 Conditional formatting with DataFrame.style
tabulate 0.8.7 Printing in Markdown-friendly format (see `tabulate`_)
Expand Down
2 changes: 1 addition & 1 deletion doc/source/whatsnew/v1.3.0.rst
Original file line number Diff line number Diff line change
Expand Up @@ -645,7 +645,7 @@ If installed, we now require:
+-----------------+-----------------+----------+---------+
| mypy (dev) | 0.812 | | X |
+-----------------+-----------------+----------+---------+
| setuptools | 38.6.0 | | X |
| setuptools | 51.0.0 | | X |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this for users building pandas from source or users using a pre-built pandas with matplotlib?

+-----------------+-----------------+----------+---------+

For `optional libraries <https://pandas.pydata.org/docs/getting_started/install.html>`_ the general recommendation is to use the latest version.
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# Minimum requirements for the build system to execute.
# See https://github.com/scipy/scipy/pull/12940 for the AIX issue.
requires = [
"setuptools>=38.6.0",
"setuptools>=51.0.0",
"wheel",
"Cython>=0.29.21,<3", # Note: sync with setup.py
# Numpy requirements for different OS/architectures
Expand Down