-
- Notifications
You must be signed in to change notification settings - Fork 19.4k
Bug fix - cannot construct Index of empty tuples #46238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jreback merged 61 commits into pandas-dev:main from weikhor:bug_fix_cannot_construct_Index_of_empty_tuples Mar 28, 2022
Merged
Bug fix - cannot construct Index of empty tuples #46238
jreback merged 61 commits into pandas-dev:main from weikhor:bug_fix_cannot_construct_Index_of_empty_tuples Mar 28, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
| this is failing a lot of tests. |
Contributor Author
| Yes. I need to fix codes to include all test cases. |
jreback requested changes Mar 6, 2022
…_cannot_construct_Index_of_empty_tuples
…_cannot_construct_Index_of_empty_tuples
…_cannot_construct_Index_of_empty_tuples
…_cannot_construct_Index_of_empty_tuples
…s://github.com/weikhor/pandas into bug_fix_cannot_construct_Index_of_empty_tuples
…_cannot_construct_Index_of_empty_tuples
mroeschke reviewed Mar 24, 2022
mroeschke reviewed Mar 24, 2022
Member
mroeschke left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good. Just needs a whatsnew note
jreback reviewed Mar 25, 2022
mroeschke reviewed Mar 26, 2022
mroeschke reviewed Mar 26, 2022
Member
mroeschke left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comment otherwise LGTM
Contributor Author
| Thank for review. |
mroeschke approved these changes Mar 26, 2022
jreback approved these changes Mar 28, 2022
Contributor
| thanks @weikhor |
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.