Skip to content

Conversation

@weikhor
Copy link
Contributor

@weikhor weikhor commented Mar 5, 2022

@weikhor weikhor changed the title cannot construct Index of empty tuples Bug fix - cannot construct Index of empty tuples Mar 5, 2022
@jreback jreback added the Index Related to the Index class or subclasses label Mar 5, 2022
@jreback
Copy link
Contributor

jreback commented Mar 5, 2022

this is failing a lot of tests.

@weikhor
Copy link
Contributor Author

weikhor commented Mar 6, 2022

Yes. I need to fix codes to include all test cases.

@jreback jreback added this to the 1.5 milestone Mar 6, 2022
@weikhor weikhor requested a review from jreback March 12, 2022 15:11
@weikhor weikhor requested a review from jreback March 24, 2022 13:06
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Just needs a whatsnew note

@jreback jreback added this to the 1.5 milestone Mar 25, 2022
@weikhor weikhor requested review from jreback and mroeschke March 25, 2022 01:40
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment otherwise LGTM

@weikhor weikhor requested a review from mroeschke March 26, 2022 03:49
@weikhor
Copy link
Contributor Author

weikhor commented Mar 26, 2022

Thank for review.

@jreback jreback merged commit 9a2d9ea into pandas-dev:main Mar 28, 2022
@jreback
Copy link
Contributor

jreback commented Mar 28, 2022

thanks @weikhor

yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Index Related to the Index class or subclasses MultiIndex

4 participants