Skip to content

BUG: Raise error when expr does not evaluate to bool in df.query #46862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

BUG: Raise error when expr does not evaluate to bool in df.query #46862

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
cca41f3
Add failing test to df.query
NumberPiOso Apr 25, 2022
4e99d29
Report error when non boolean dtype df.query
NumberPiOso Apr 25, 2022
fffdcc8
Special case when res.dim > 1
NumberPiOso Apr 25, 2022
b8e1aa4
Add whatsnew entry
NumberPiOso Apr 25, 2022
3ae076c
Fix boolean typo
NumberPiOso Apr 25, 2022
b0224a7
Refactor checking boolean df.query
NumberPiOso Apr 26, 2022
2ba87ed
Add raising error test ndim=2 in df.query
NumberPiOso Apr 26, 2022
f4a43e5
Refactor to avoid try: except:
NumberPiOso May 23, 2022
fddf50a
Merge branch 'main' into query-error
NumberPiOso Jun 10, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Report error when non boolean dtype df.query
  • Loading branch information
@NumberPiOso
NumberPiOso committed Apr 25, 2022
commit 4e99d2923535c8745da050e5abf54b4fc2ec559b
4 changes: 3 additions & 1 deletion pandas/core/frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4134,7 +4134,9 @@ def query(self, expr: str, inplace: bool = False, **kwargs):
kwargs["level"] = kwargs.pop("level", 0) + 1
kwargs["target"] = None
res = self.eval(expr, **kwargs)

if not is_bool_dtype(res):
msg = f"expr must evaluate to boolean not {res.dtypes}"
raise ValueError(msg)
Copy link
Member

@simonjayhawkins simonjayhawkins May 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of curiosity, as not looked at this in detail, but if we are ensuring a bool indexer, is the following try/except still needed?
Copy link
Contributor Author

@NumberPiOso NumberPiOso May 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed it is a common problem with the multidimensional res, so we can share the solution.
try:
result = self.loc[res]
except ValueError:
Expand Down