Skip to content

Improve error message for DataFrame.from_dict when wrong orient is provided #47451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jun 24, 2022
Merged

Improve error message for DataFrame.from_dict when wrong orient is provided #47451

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
7240eca
Fixed error message
KianShah Jun 21, 2022
de3cc11
Update v1.4.3.rst
KianShah Jun 21, 2022
cc41d3a
Update v1.4.3.rst
KianShah Jun 21, 2022
bffe1c1
Added test case
KianShah Jun 21, 2022
efcf89a
Merge branch 'pandas-dev:main' into fix_error_msg
KianShah Jun 21, 2022
0ac0e7d
Merge branch 'fix_error_msg' of github.com:KianShah/pandas into fix_e…
KianShah Jun 21, 2022
16ccf81
Added test
KianShah Jun 21, 2022
869d8bc
Fix rst file
KianShah Jun 22, 2022
d47c818
Fix black issues
KianShah Jun 22, 2022
4732c24
Merge branch 'fix_error_msg' of github.com:KianShah/pandas into fix_e…
KianShah Jun 23, 2022
d34cc8d
Merge branch 'fix_error_msg' of github.com:KianShah/pandas into fix_e…
KianShah Jun 23, 2022
4691aad
Merge branch 'main' into fix_error_msg
KianShah Jun 23, 2022
a2d6860
Fixed error msg and corresponding test
KianShah Jun 23, 2022
6b43dda
improved changelog
KianShah Jun 23, 2022
fd78ffd
Also fix python docstring for :func:to_dict
KianShah Jun 23, 2022
be1fc49
Merge branch 'pandas-dev:main' into fix_error_msg
KianShah Jun 23, 2022
928bdf7
Fix failing test
KianShah Jun 23, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update v1.4.3.rst
  • Loading branch information
@KianShah
KianShah authored Jun 21, 2022
commit cc41d3a66c6d1d52728da73348dd5cfed9d2c5bc
2 changes: 1 addition & 1 deletion doc/source/whatsnew/v1.4.3.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ Bug fixes
~~~~~~~~~
- Bug in :meth:`pd.eval`, :meth:`DataFrame.eval` and :meth:`DataFrame.query` where passing empty ``local_dict`` or ``global_dict`` was treated as passing ``None`` (:issue:`47084`)
- Most I/O methods do no longer suppress ``OSError`` and ``ValueError`` when closing file handles (:issue:`47136`)
- Fixed unintuitive error message in :meth:`DataFrame.from_dict` that didn't list 'tight' as an acceptable parameter
- Added parameter `tight` in :meth:`DataFrame.from_dict` error message

.. ---------------------------------------------------------------------------

Expand Down