Fixed metadata propagation in Dataframe.idxmax and Dataframe.idxmin #… #47821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Hello @SomtochiUmeh! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2022-07-22 18:16:36 UTC |
mzeitlin11 reviewed Jul 22, 2022
Member
mzeitlin11 left a comment
mzeitlin11 left a comment There was a problem hiding this comment.
Thanks for the pr @SomtochiUmeh! One small comment
Member
| Also, please see https://pandas.pydata.org/docs/development/contributing_codebase.html#pre-commit for how to fix that CI failure |
mzeitlin11 approved these changes Jul 22, 2022
Member
mzeitlin11 left a comment
mzeitlin11 left a comment There was a problem hiding this comment.
LGTM, thanks @SomtochiUmeh!
mroeschke approved these changes Jul 25, 2022
Member
| Thanks @SomtochiUmeh |
dannyi96 added a commit to dannyi96/pandas that referenced this pull request Jul 26, 2022
…idxmin #… (pandas-dev#47821)" This reverts commit b0a51fe.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
…28283