1.4.x #48120
Closed
1.4.x #48120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
fix a bug of at indexer: when using df.at[slice, item] = array for existed item it will raise the pandas.errors.InvalidIndexError
Update frame.py
datapythonista requested changes Aug 17, 2022
Member
datapythonista left a comment
datapythonista left a comment There was a problem hiding this comment.
Thanks for the contribution @agodbug, some comments:
- Can you provide a useful title so we understand what this is about please
- Can you leave the template of the PR with the bullet points there, and check the points that you completed (and complete them all please)
- Can you link to an issue if what you're addressing here has an issue. If it doesn't, can you add one with a minimal code examples that shows the bug
- Why is this PR is against
1.4.xbranch and not tomain? - Can you add a note to the release notes about what you're fixing
- Can you add a test that shows the bug that you're fixing (so it fails before your fix, and passes after your fix)
Thank you!
datapythonista added Bug Needs Info 
Member
I don't think you can change that after the PR is opened? so closing this one. @agodbug please reopen PR against main. (after considering the points raised in #48120 (review)) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
fix a bug using at to setitem will raise InvalidIndexError: df.at[slice, item] = array_or_other if item existed