Skip to content

Conversation

@MarcoGorelli
Copy link
Member

@MarcoGorelli MarcoGorelli commented Nov 27, 2022

@mroeschke mroeschke added the metadata _metadata, .attrs label Nov 28, 2022
@jbrockmendel
Copy link
Member

If this works I'm pretty sure it'll close #34373.

When we're ready to discuss deprecations for 3.0, I think we should kill off __finalize__. There's no real prospect of getting it fully-working.

@github-actions
Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Dec 30, 2022
@MarcoGorelli
Copy link
Member Author

I'll get back to this later

When we're ready to discuss deprecations for 3.0, I think we should kill off finalize. There's no real prospect of getting it fully-working.

yeah agreed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

metadata _metadata, .attrs Stale

3 participants