CLN, TST: clean up and increase coverage in tslib.pyx #50439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
MarcoGorelli commented Dec 26, 2022
Comment on lines -90 to -94
| if ts == "now": | ||
| return Timestamp.utcnow() | ||
| elif ts == "today": | ||
| return Timestamp.now().normalize() | ||
| |
Member Author
There was a problem hiding this comment.
this function is only used for testing of the ISO fastpath. there's no test that has 'now' or 'today', and they wouldn't test the ISO fastpath anyway, so might as well remove them
| tz: tzinfo | None = ..., | ||
| format: str | None = ..., | ||
| na_rep: object = ..., | ||
| na_rep: str | float = ..., |
Member Author
There was a problem hiding this comment.
format_array_from_datetime is only called from
pandas/pandas/core/arrays/datetimes.py
Lines 709 to 718 in 7c208c8
, where na_rep can't be None
Comment on lines +47 to +57
| result = index._format_native_types(date_format="%Y-%m-%d %H:%M:%S.%f") | ||
| expected = np.array( | ||
| ["2017-01-01 00:00:00.000000", "NaT", "2017-01-03 00:00:00.000000"], | ||
| dtype=object, | ||
| ) | ||
| tm.assert_numpy_array_equal(result, expected) | ||
| | ||
| # invalid format | ||
| result = index._format_native_types(date_format="foo") | ||
| expected = np.array(["foo", "NaT", "foo"], dtype=object) | ||
| tm.assert_numpy_array_equal(result, expected) |
Member Author
There was a problem hiding this comment.
just increasing coverage
| ("2011\\01\\02", datetime(2011, 1, 2)), | ||
| ("2013-01-01 05:30:00", datetime(2013, 1, 1, 5, 30)), | ||
| ("2013-1-1 5:30:00", datetime(2013, 1, 1, 5, 30)), | ||
| ("2013-1-1 5:30:00+01:00", Timestamp(2013, 1, 1, 5, 30, tz="UTC+01:00")), |
Member Author
There was a problem hiding this comment.
increasing coverage
MarcoGorelli changed the title 
mroeschke approved these changes Dec 27, 2022
Member
| Thanks @MarcoGorelli |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.