-
- Notifications
You must be signed in to change notification settings - Fork 19.4k
API: Timestamp and Timedelta .value changing in 2.0 #50891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 18 commits
Commits
Show all changes
24 commits Select commit Hold shift + click to select a range
84ea60f wip
540113a wip
82da04f fixup test collection
c026a4f divide by zero to debug LOL
378dbef wip
dd6d8b4 more fixups
af97b06 fixup test unary ops
aeb49d7 ewm
1f271ca test offseetes
3b96637 are we there yet?
b0c4098 Merge remote-tracking branch 'upstream/main' into timestamp-value
a5aa8e0 _value in ujson
50476ca Merge remote-tracking branch 'upstream/main' into timestamp-value
a0cf7d4 :label: typing
255c4bd Merge remote-tracking branch 'upstream/main' into timestamp-value
db72dd7 wip
16003f9 advise to use asm8 instead
0a2cec7 Merge branch 'main' into timestamp-value
MarcoGorelli 2a11315 Merge remote-tracking branch 'upstream/main' into timestamp-value
2b4da6c fix test missing
8813511 Merge remote-tracking branch 'upstream/main' into timestamp-value
9b50ffa make value property
79b3f13 un-xfail test
ea4d898 Merge remote-tracking branch 'upstream/main' into timestamp-value
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| | @@ -89,6 +89,7 @@ class Timedelta(timedelta): | |
| max: ClassVar[Timedelta] | ||
| resolution: ClassVar[Timedelta] | ||
| value: int # np.int64 | ||
| _value: int # np.int64 | ||
| Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. to be Technically Correct do we need to make value a property here? | ||
| # error: "__new__" must return a class instance (got "Union[Timestamp, NaTType]") | ||
| def __new__( # type: ignore[misc] | ||
| cls: type[_S], | ||
| | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.