WEB: Add code highlighting in PDEPs and render tables correctly #51458
Conversation
| Nvm, we basically have the same thing as pydata-sphinx-theme, the only difference is that we don't have the box around the code block so it still looks kinda nasty. |
|
This is what it looks like. |
| We clearly have been noticing the same things ;) The last days, I was thinking we could also use sphinx (with myst) instead to solve many of those issues. I wrote up #51461 about that |
datapythonista left a comment
datapythonista left a comment There was a problem hiding this comment.
Lookg great, thanks @lithomas1
| ) | ||
| # Apply Bootstrap's table formatting manually | ||
| # Python-Markdown doesn't let us config table attributes by hand | ||
| body = body.replace("<table>", '<table class="table table-bordered">') |
There was a problem hiding this comment.
Really nice. At some point I thought on creating a plugin for python markdown to do this (the core dev doesn't want to add anything into the project, which is probably good). But didn't think about this as a workaround.
| Preview docs at: https://pandas.pydata.org/preview/51458/ |
| Looks like you're changing the background color of the navigation bar, not sure if that's intended. I like how it looks like actually, but feels like this PR shouldn't change it, right? Also, we can address it in a follow up PR, but I think we can add some padding and maybe a border to the code boxes: https://pandas.pydata.org/preview/51458/pdeps/0004-consistent-to-datetime-parsing.html Happy to take care of that myself in a follow up PR, but probably easy to add it here too. |
My bad. Just realized now that I'm in a different monitor, where the color looks darker. Interesting that everything else looks the same, except of our navigation bar. Sorry about the noise. |
Thanks @lithomas1. I think we can address the above comment in a follow up, but nice improvement to the website! |
3 participants
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Discovered that tables were rendering really nastily and there was no code highlighting so PDEPs were looking a little bland while working on PDEP 7.
Note: The codehilite.css file that I added was generated by pygments, and is based on the
friendlystyle(I'll try to find the pydata-sphinx-theme style css file though).