WEB: Added stying for pre element within the codeblock divs #51665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

datapythonista merged 2 commits into pandas-dev:main from dsamuel27:codeblockstyling

Mar 7, 2023

Contributor

dsamuel27 commented Feb 27, 2023 •

edited

Loading

closes #WEB: Improve the style of the code boxes in the website #51657 (Replace xxxx with the GitHub issue number)
ENH: Enhancement, adding styling (padding and border) for code blocks

Added stying for pre element within the codeblock divs

dc9cbc2

Contributor Author

dsamuel27 commented Feb 27, 2023 •

edited

Loading

I was reviewing the stylesheets. Would you rather have me add the new styling to codehilite.css since it's effecting the codehilite class?

phofl requested a review from datapythonista

February 27, 2023 10:53

datapythonista approved these changes

View reviewed changes

Member

datapythonista left a comment

Thanks for taking care of this @dsamuel27, I had a look at the rendered version and looks great.

I was reviewing the stylesheets. Would you rather have me add the new styling to codehilite.css since it's effecting the codehilite class?

I guess it's a more natural place to be, yes. @lithomas1 do you want to have a look here?

datapythonista changed the title ~~Added stying for pre element within the codeblock divs~~ WEB: Added stying for pre element within the codeblock divs

datapythonista added the Web label

Moved styling to codehilite.css

60f1895

Contributor Author

dsamuel27 commented Feb 28, 2023

I ended up moving the css code to codehilite.css

Member

datapythonista commented Mar 1, 2023

I ended up moving the css code to codehilite.css

Great, probably better. I'll someone else from the core dev team have a second look and merge, otherwise I'll merge myself in couple of days. But this should be good to go.

Member

datapythonista commented Mar 1, 2023

/preview

Contributor

github-actions bot commented Mar 1, 2023

Website preview of this PR available at: https://pandas.pydata.org/preview/51665/

Member

datapythonista commented Mar 1, 2023

Website preview of this PR available at: https://pandas.pydata.org/preview/51665/

An example of where the changes can be seen is here: https://pandas.pydata.org/preview/51665/pdeps/0004-consistent-to-datetime-parsing.html

datapythonista merged commit f9be5d9 into pandas-dev:main

Member

datapythonista commented Mar 7, 2023

Thanks @dsamuel27, very nice!

datapythonista mentioned this pull request

WEB: Improve the style of the code boxes in the website #51657

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment