Skip to content
Closed
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
7a28708
DEPR: allowing non-class returns for _constructor etc
jbrockmendel Apr 4, 2023
3d9d7cd
lint fixup
jbrockmendel Apr 4, 2023
894ad3c
Merge branch 'main' into depr-constructor
jbrockmendel Apr 11, 2023
9968cf9
"fix new test"
jbrockmendel Apr 11, 2023
373a7c7
Merge branch 'main' into depr-constructor
jbrockmendel Apr 13, 2023
9756d5e
Merge branch 'main' into depr-constructor
jbrockmendel Apr 19, 2023
eb39b47
Merge branch 'main' into depr-constructor
jbrockmendel Apr 19, 2023
c259ac8
Merge branch 'main' into depr-constructor
jbrockmendel Apr 20, 2023
0b46c98
Merge branch 'main' into depr-constructor
jbrockmendel Apr 21, 2023
45c9218
Merge branch 'main' into depr-constructor
jbrockmendel Apr 28, 2023
0d01eea
Merge branch 'main' into depr-constructor
jbrockmendel May 4, 2023
918a707
Merge branch 'main' into depr-constructor
jbrockmendel May 8, 2023
24a9041
Merge branch 'main' into depr-constructor
jbrockmendel Jul 18, 2023
0afc695
Merge branch 'main' into depr-constructor
jbrockmendel Jul 26, 2023
10ded72
Merge branch 'main' into depr-constructor
jbrockmendel Jul 27, 2023
90cb220
Merge branch 'main' into depr-constructor
jbrockmendel Jul 28, 2023
c824432
Merge branch 'main' into depr-constructor
jbrockmendel Aug 23, 2023
d1f48d8
Merge branch 'main' into depr-constructor
jbrockmendel Aug 31, 2023
99d1770
Merge branch 'main' into depr-constructor
jbrockmendel Sep 1, 2023
521402c
Merge branch 'main' into depr-constructor
jbrockmendel Sep 1, 2023
d7c3510
Merge branch 'main' into depr-constructor
jbrockmendel Sep 1, 2023
97bbb51
Merge branch 'main' into depr-constructor
jbrockmendel Sep 18, 2023
9cd4be4
Merge branch 'main' into depr-constructor
jbrockmendel Oct 13, 2023
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
"fix new test"
  • Loading branch information
jbrockmendel committed Apr 11, 2023
commit 9968cf997e19585ba2768392de3ddfc621faaf8e
23 changes: 14 additions & 9 deletions pandas/tests/series/test_subclass.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import warnings

import numpy as np
import pytest

Expand Down Expand Up @@ -60,16 +62,19 @@ def test_equals(self):
assert s2.equals(s1)


class SubclassedSeries(pd.Series):
@property
def _constructor(self):
def _new(*args, **kwargs):
# some constructor logic that accesses the Series' name
if self.name == "test":
return pd.Series(*args, **kwargs)
return SubclassedSeries(*args, **kwargs)
with warnings.catch_warnings():
warnings.simplefilter("ignore")

class SubclassedSeries(pd.Series):
@property
def _constructor(self):
def _new(*args, **kwargs):
# some constructor logic that accesses the Series' name
if self.name == "test":
return pd.Series(*args, **kwargs)
return SubclassedSeries(*args, **kwargs)

return _new
return _new


def test_constructor_from_dict():
Expand Down