Skip to content

TYP: Narrow down type of method keyword in Index #52723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 7, 2023
Merged

TYP: Narrow down type of method keyword in Index #52723

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
30a68ce
Add literal type hint.
kklein Apr 18, 2023
52f163d
Move type variable to _typing.py.
kklein Apr 18, 2023
8c970db
Merge branch 'main' of https://github.com/pandas-dev/pandas into inde…
kklein May 6, 2023
d378afc
Use existing type alias.
kklein May 6, 2023
10c02c4
EOF
kklein May 6, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pandas/core/indexes/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,7 @@
_index_shared_docs: dict[str, str] = {}
str_t = str

IndexMethod = Literal["pad", "ffill", "backfill", "bfill", "nearest"]

_dtype_obj = np.dtype("object")

Expand Down Expand Up @@ -3742,7 +3743,7 @@ def get_loc(self, key):
def get_indexer(
self,
target,
method: str_t | None = None,
method: IndexMethod | None = None,
limit: int | None = None,
tolerance=None,
) -> npt.NDArray[np.intp]:
Expand Down Expand Up @@ -4197,7 +4198,7 @@ def _validate_can_reindex(self, indexer: np.ndarray) -> None:
def reindex(
self,
target,
method=None,
method: IndexMethod | None = None,
level=None,
limit: int | None = None,
tolerance: float | None = None,
Expand Down