Doc: fixed missing behavior explaination of sort=false for groupby issue #47529 #52736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor Author
| Reviewer suggestions: @phofl, @noatamir, @jorisvandenbossche and @MarcoGorelli |
MarcoGorelli suggested changes Apr 19, 2023
doc/source/user_guide/groupby.rst Outdated
| Note that ``groupby`` will preserve the order in which *observations* are sorted *within* each group. | ||
| Note that ``groupby`` will preserve the order in which *observations* are sorted *within* each group . |
Contributor Author
There was a problem hiding this comment.
In the comments of the issue it was mentioned to add also a description in the "User Guide".
Member
There was a problem hiding this comment.
@raanasn - it looks like you're adding an unnecessary space before the period here.
Member
There was a problem hiding this comment.
exactly - if you revert this the rest look good to me
Co-authored-by: Marco Edward Gorelli <33491632+MarcoGorelli@users.noreply.github.com>
Member
| Thanks @raanasn! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Changes were made by @hubschne and @raanasn at the python conference 2023 Berlin workshop