BUG: crosstab(dropna=False) did not keep np.nan in result #53205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

phofl merged 1 commit into pandas-dev:main from mroeschke:bug/crosstab/dropna

May 14, 2023

+39 −13

Member

mroeschke commented May 12, 2023 •

edited

Loading

closes BUG: crosstab(dropna=False) does not work like value_counts(dropna=False) #10772 (Replace xxxx with the GitHub issue number)
Tests added and passed if fixing a bug or adding a new feature
All code checks passed.
Added type annotations to new arguments/methods/functions.
Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

BUG: crosstab(dropna=False) did not keep np.nan in result

14d5919

mroeschke added Missing-data Reshaping labels

mroeschke added this to the 2.1 milestone

phofl approved these changes

View reviewed changes

phofl merged commit 3cfd868 into pandas-dev:main

Member

phofl commented May 14, 2023

Contributor

nickeubank commented May 14, 2023

THANK YOU! @mroeschke

mroeschke deleted the bug/crosstab/dropna branch

May 14, 2023 17:47

Rylie-W pushed a commit to Rylie-W/pandas that referenced this pull request

BUG: crosstab(dropna=False) did not keep np.nan in result (pandas-dev…

6757a34

…#53205)

topper-123 pushed a commit to topper-123/pandas that referenced this pull request

BUG: crosstab(dropna=False) did not keep np.nan in result (pandas-dev…

a0aa141

…#53205)

Daquisu pushed a commit to Daquisu/pandas that referenced this pull request

BUG: crosstab(dropna=False) did not keep np.nan in result (pandas-dev…

390a908

…#53205)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment