Skip to content

Add type literals to engine argument in groupby aggregations #54141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 17, 2023
Merged

Add type literals to engine argument in groupby aggregations #54141

merged 3 commits into from
Jul 17, 2023

Conversation

@ankile
Copy link
Contributor

@ankile ankile commented Jul 15, 2023 •
edited
Loading

@noatamir @phofl SciPy 2023 Sprint!
@ankile ankile requested a review from rhshadrach as a code owner July 15, 2023 17:04
@noatamir noatamir added the Sprints Sprint Pull Requests label Jul 15, 2023
@ankile ankile changed the title Typing/groupby engine Add type literals to engine argument in groupby aggregations Jul 15, 2023
@phofl phofl added the Typing type annotations, mypy/pyright type checking label Jul 17, 2023
@phofl phofl added this to the 2.1 milestone Jul 17, 2023
phofl
phofl approved these changes Jul 17, 2023
View reviewed changes
@phofl phofl merged commit 098a569 into pandas-dev:main Jul 17, 2023
@phofl
Copy link
Member

phofl commented Jul 17, 2023

thx @ankile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Sprints Sprint Pull Requests Typing type annotations, mypy/pyright type checking

3 participants

@ankile @phofl @noatamir