TYP: Add typing.overload signatures to DataFrame.drop_duplicates. #54281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This adds overloads so that a type checker can determine whether drop_duplicates returns DataFrame or None based on the value of the `inplace` argument.
twoertwein approved these changes Jul 28, 2023
Member
| Thank you @rchen152! |
Contributor Author
| Thanks for the quick review and merge :) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This adds overloads so that a type checker can determine whether drop_duplicates returns DataFrame or None based on the value of the
inplaceargument.The motivation for this is that we're using a type checker that looks at the pandas source code for type information. I realize that we should be using the stubs instead, but this will unblock us in the meantime and seems like an improvement to the type annotations anyway.