TYP: enable reportGeneralTypeIssues for more files #54423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
twoertwein commented Aug 5, 2023
| pythonVersion = "3.10" | ||
| pythonVersion = "3.11" | ||
| typeCheckingMode = "basic" | ||
| useLibraryCodeForTypes = false |
Member Author
There was a problem hiding this comment.
To prevent pyright from analyzing non-py.typed libraries such as matplotlib
twoertwein commented Aug 5, 2023
| if is_iterator(keys): | ||
| keys = list(keys) | ||
| if is_iterator(objs): | ||
| objs = list(objs) |
Member Author
There was a problem hiding this comment.
This if should not be needed as objs was always a list at that point - let's see whether the tests agree.
twoertwein requested review from Dr-Irv, attack68 and rhshadrach as code owners 
rhshadrach reviewed Aug 5, 2023
Member
rhshadrach left a comment
rhshadrach left a comment There was a problem hiding this comment.
lgtm, but I'm not really familiar with the time-series related changes. Would be good to have another eye here @MarcoGorelli
mroeschke approved these changes Aug 7, 2023
Member
| Thanks @twoertwein |
mroeschke pushed a commit to mroeschke/pandas that referenced this pull request Aug 18, 2023
* TYP: enable reportGeneralTypeIssues for more files * fixes * Added some time-related annotations based on the tests from pandas-stubs * remove python version from second pyright config file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Most changes are in io/excel but also in files where pyright had one or two violates to get those files off the list.