MAINT: Remove np.in1d function calls #54694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mroeschke approved these changes Aug 22, 2023
mroeschke added the Compat 
Member
| Thanks @mtsokol |
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Hi!
This PR changes
np.in1dcalls tonp.isinasnp.in1dis being made private in numpy/numpy#24445.I wasn't sure if arrays passed to it are surely 1d, therefore I called
.ravel()to fully reproducein1dbehavior. If any of these lines actually operate on 1d arrays, thenisinandin1dcan be used interchangeably.