TST: add test case of ngroup with NaN value #54966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Co-authored-by: José Lucas Silva Mayer <josemayer@usp.br> Co-authored-by: Willian Wang <git@willian.wang>
Signed-off-by: José Lucas Silva Mayer <josemayer@usp.br>
Co-authored-by: José Lucas Silva Mayer <josemayer@usp.br> Co-authored-by: Willian Wang <git@willian.wang>
Co-authored-by: José Lucas Silva Mayer <josemayer@usp.br> Co-authored-by: Willian Wang <git@willian.wang>
3 tasks
mroeschke reviewed Sep 5, 2023
Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Signed-off-by: José Lucas Silva Mayer <josemayer@usp.br>
mroeschke approved these changes Sep 6, 2023
Member
| Thanks @josemayer |
mroeschke added a commit to mroeschke/pandas that referenced this pull request Sep 11, 2023
* add test case of ngroup with nan value Co-authored-by: José Lucas Silva Mayer <josemayer@usp.br> Co-authored-by: Willian Wang <git@willian.wang> * fix linter issues Co-authored-by: José Lucas Silva Mayer <josemayer@usp.br> Co-authored-by: Willian Wang <git@willian.wang> * use Categorical object instead of pd.Categorical Co-authored-by: José Lucas Silva Mayer <josemayer@usp.br> Co-authored-by: Willian Wang <git@willian.wang> * use native assert function Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com> * test full result of ngroup method Signed-off-by: José Lucas Silva Mayer <josemayer@usp.br> --------- Signed-off-by: José Lucas Silva Mayer <josemayer@usp.br> Co-authored-by: Willian Wang <git@willian.wang> Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
GroupBy.ngroupmethod, which ensure consistency returning a 0 value.