TYP: Add typing.overload signatures to DataFrame/Series.interpolate #54999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This will help our type checker work better and is a plain improvement to the type hints.
Contributor Author
| pre-commit.ci autofix |
for more information, see https://pre-commit.ci
twoertwein approved these changes Sep 4, 2023
Member
| Thank you @caneff! Pyright/mypy pass, CI failures seem unrelated. |
mroeschke pushed a commit to mroeschke/pandas that referenced this pull request Sep 11, 2023
…andas-dev#54999) * Add inplace overloads for interpolate This will help our type checker work better and is a plain improvement to the type hints. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This adds overloads so that a type checker can determine whether interpolate returns DataFrame/Series or None based on the value of the inplace argument.
This is more of the same thing that was done in this pull.