DEV: don't install tables on MacOS ARM in dev requirements.txt (add env markers) #55167
+41 −14
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When installing dependencies via pip on Mac M1 or M2 installing tables is not trivial and throws an error (see below) because wheels of tables for this hardware is not available and building depends on hdf5.
The solution is to exclude the install of tables via environment markers in the
requirements-dev.txt. This file is generated byscripts/generate_pip_deps_from_conda.py.This commit adds the following functionality to
scripts/generate_pip_deps_from_conda.py:Adding environment markers to dependencies specified in
ADD_ENV_MARKERS.Allow multiple operations on the same package (add env markers, rename package and remap version).
closes #xxxx (Replace xxxx with the GitHub issue number)
Tests added and passed if fixing a bug or adding a new feature
All code checks passed.
Added type annotations to new arguments/methods/functions.
Added an entry in the latest
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.error installing tables