Compiled pandas with -Wextra #56327
Merged
Compiled pandas with -Wextra #56327
+189 −139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
WillAyd commented Dec 5, 2023
| | ||
| static PyMethodDef ujsonMethods[] = { | ||
| {"ujson_dumps", (PyCFunction)objToJSON, METH_VARARGS | METH_KEYWORDS, | ||
| {"ujson_dumps", (PyCFunction)(void (*)(void))objToJSON, |
Member Author
There was a problem hiding this comment.
I find this cast here a bit strange but it is what CPython has in their documentation for functions that accept kwargs
https://docs.python.org/3/extending/extending.html#keyword-parameters-for-extension-functions
mroeschke reviewed Dec 7, 2023
| #define toupper_ascii(c) ((((unsigned)(c) - 'a') < 26) ? ((c) & 0x5f) : (c)) | ||
| #define tolower_ascii(c) ((((unsigned)(c) - 'A') < 26) ? ((c) | 0x20) : (c)) | ||
| | ||
| #define UNUSED(x) (void)(x) |
Member
There was a problem hiding this comment.
Just curious why this is needed
Member Author
There was a problem hiding this comment.
Unused parameters trigger a warning, and there is no cross platform way to silence them. Gcc/clang have an unused attribute. I'm not aware of something for MSVC
Python offers a Py_UNUSED macro for this purpose too. Let me see if we can switch over to that so it's one less thing we manage
mroeschke approved these changes Dec 9, 2023
Member
| Thanks @WillAyd |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Need to merge in #56277 first then make sure this doesn't cause issues on other platforms, but seems to work for gcc