-
- Notifications
You must be signed in to change notification settings - Fork 19.4k
Bug: fix Series.str.split when 'regex=None' for series having 'pd.ArrowDtype(pa.string())' dtype #58418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Bug: fix Series.str.split when 'regex=None' for series having 'pd.ArrowDtype(pa.string())' dtype #58418
Changes from 1 commit
Commits
Show all changes
14 commits Select commit Hold shift + click to select a range
0349837 Add test
yuanx749 4948784 Fix
yuanx749 14c059c Add whatsnew
yuanx749 f55ca62 Merge remote-tracking branch 'upstream/main' into split-arrow
yuanx749 f0c2097 Move logic outside
yuanx749 6f93a8d Move test
yuanx749 b9b3197 Revert "Move test"
yuanx749 d919957 Add test
yuanx749 5fd5bcb Merge remote-tracking branch 'upstream/main' into split-arrow
yuanx749 a7f8af2 Merge remote-tracking branch 'upstream/main' into split-arrow
yuanx749 20e5ebe pass mypy type check
yuanx749 14fd864 keep _str_split
yuanx749 cd802ac Merge remote-tracking branch 'upstream/main' into split-arrow
yuanx749 ab5f337 Merge remote-tracking branch 'upstream/main' into split-arrow
yuanx749 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Move test
- Loading branch information
commit 6f93a8d9a8d50acbbf055b328cc51ccce2018a11
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would actually prefer to just add the
pd.ArrowDtype(pa.string())to the existing string dtypes instead of copying and creating a new fixture. Guessing that causes a lot of other test failures?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I forgot that
pd.ArrowDtype(pa.string())was not actually in the fixture, so my suggestion lead you a bit in the wrong way. Sorry!Right now adding this to the main
any_string_dtypefixture will indeed give quite some failures, yes. I agree that it might be better to actually do that (and it would be interesting to see which tests actually fail), but that's for another PR / out of scope for this bug fix (doing so would also require removing some tests are now only exist for the arrow string dtype, to not keep things duplicated).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, a lot of other tests need to be adjusted if adding ArrowDtype to the fixture.
So for this PR, should I just add test in
pandas/tests/extension/test_arrow.py?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened #58495 so we can track the larger issue