Skip to content

Conversation

@sinhrks
Copy link
Member

@sinhrks sinhrks commented Mar 30, 2014

Closes #4606.

I'm not sure this also be a solution for #5388, but seems to be a workaround.

@jreback jreback added this to the 0.14.0 milestone Mar 30, 2014
@jreback jreback added Dtypes and removed Compat labels Mar 30, 2014
@jreback
Copy link
Contributor

jreback commented Mar 30, 2014

@sinhrks ok...this is ok for #4606 (though do you really need that separate function _nat_upickle?

This 'solves' #5388 but not for the right reason. This is of course object type, but can represented if transposed into 'correct' blocks.

I am not sure what to do about this. Multi-dtypes have to be inserted into a Panel on only certain axes otherwise it forces object.

So pls pull out the tests for #5388. Let's keep that as a separate issue.

In [36]: wp.to_frame() Out[36]: i1 i2 major minor 0 A 1 1 B 2010-01-01 00:00:00 2010-01-01 00:00:00 1 A 2 2 [3 rows x 2 columns] In [37]: wp.to_frame().dtypes Out[37]: i1 object i2 object dtype: object In [38]: wp.transpose(2,0,1).to_frame().dtypes Out[38]: A object B datetime64[ns] dtype: object In [39]: wp.transpose(2,0,1).to_frame() Out[39]: A B major minor i1 0 1 2010-01-01 i2 0 1 2010-01-01 [2 rows x 2 columns] 
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can take this out of here.

@jreback
Copy link
Contributor

jreback commented Mar 31, 2014

merged via 2ada054

thanks!

@sinhrks
Copy link
Member Author

sinhrks commented Mar 31, 2014

Thanks to merge.

though do you really need that separate function _nat_upickle?

I believe so, because pickle module search the function under the module namespace and raise PicklingError if it cannot find it.

@jreback
Copy link
Contributor

jreback commented Mar 31, 2014

got it...thanks

@sinhrks sinhrks deleted the nat_pickle branch April 6, 2014 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dtype Conversions Unexpected or buggy dtype conversions Internals Related to non-user accessible pandas implementation IO Data IO issues that don't fit into a more specific label Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate

2 participants