update to holiday to help with GH#7070

[MichaelWS]

I am working on a financial calendar and wanted to add the following functions to pandas.tseries.holiday in order to properly handle half days.

[jreback]

looks reasonable (test failures though)

[rockg]

The right syntax would be h = Holiday("Easter Monday", month=1, day=1, offset=[Easter(), Day(1)]). However, I'm seeing a problem in python3 with the map objects. I think if we just wrap list() around the map in Holiday as it iterates through the offsets everything will work.

[MichaelWS]

Thank you very much. Should I keep a test for defined holidays?

[rockg]

I don't see any harm in that.

[MichaelWS]

Thanks for the help on this.

[MichaelWS]

@rockg, I am still crashing on a python3 build. How did you intend to handle the two observations?

[MichaelWS]

I will setup a python3 environment to test both going forward.

[rockg]

Yeah, I had to do the same. So many of my changes in the past needed
python3 specific fixes.

[jreback]

@MichaelWS looks fine, can you add a release note (just to document)

[MichaelWS]

easy enough, should I put it in v0.15.0.txt?

[jreback]

yep

[jreback]

is this doc-stringed?

[MichaelWS]

which one? The list of offsets was a bug that appeared in python3

[jreback]

it was just an untested case/bug? put the pr reference in the release note

I meant does the doc string say it should accept a list?

[MichaelWS]

It was an untested case. It takes a list or if its not a list it creates a list around what is inputted. However, two items never worked in python3.

I will edit the pr later today.

[jreback]

ok ping when done and green

[MichaelWS]

all green, I added to the init so its clear

@jreback , thanks for the help.

[jreback]

is their a test that validates this now?

[rockg]

The GoodFriday/Easter tests he added validate that it works.

[jreback]

oh i see, ok then.

[jreback]

thanks for the PR!